Skip to content

fix: Fixed migration error and downgrade function #6129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

fix: Fixed migration error and downgrade function #6129

merged 1 commit into from
Jul 1, 2019

Conversation

@mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jul 1, 2019 •
edited
Loading

Fixes #6128

Short description of what this resolves:

Changes proposed in this pull request:

  • Previously, order_expiry_time was allowed to be NULL, fixed downgrade method
  • server_default needs to be a string

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jul 1, 2019
shreyanshdwivedi
shreyanshdwivedi approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally. Working fine now. Thank you

@mrsaicharan1
Copy link
Member Author

mrsaicharan1 commented Jul 1, 2019 •
edited
Loading

@uds5501 @iamareebjamal Please review.

uds5501
uds5501 approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #6129 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6129      +/-   ##
===============================================
+ Coverage         66.5%   66.52%   +0.02%     
===============================================
  Files              286      286              
  Lines            14275    14275              
===============================================
+ Hits              9494     9497       +3     
+ Misses            4781     4778       -3
Impacted Files Coverage Δ
app/api/helpers/scheduled_jobs.py 26.31% <0%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f47412...a5a462b. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 1a837b2 into fossasia:development Jul 1, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
@mrsaicharan1 @iamareebjamal
fix: order_expiry_time migration error and downgrade function (fossas…
991edc0 
…ia#6129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+2 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

order_expiry_time migration error

4 participants

@mrsaicharan1 @iamareebjamal @uds5501 @shreyanshdwivedi